This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move fuchsia/scenic integration behind #define#19003
Merged
arbreng merged 1 commit intoflutter:masterfrom Jun 26, 2020
Merged
Conversation
arbreng
force-pushed
the
legacy-scenic-define
branch
2 times, most recently
from
b0c2cd8 to
44093cc
Compare
dreveman
reviewed
Jun 11, 2020
iskakaushik
reviewed
Jun 12, 2020
arbreng
force-pushed
the
legacy-scenic-define
branch
from
44093cc to
9801438
Compare
dreveman
reviewed
Jun 12, 2020
Contributor
dreveman
left a comment
dreveman
left a comment
There was a problem hiding this comment.
lgtm when peeps who know this code better than me are happy
arbreng
force-pushed
the
legacy-scenic-define
branch
from
9801438 to
3f4a87a
Compare
arbreng
force-pushed
the
legacy-scenic-define
branch
6 times, most recently
from
c6a6b09 to
981a186
Compare
Additionally create "_next" permutations for all of the test binaries on Fuchsia, in order to test both code-paths. Using the #define follow-up CLs can also create a flutter_runner_next binary that does not contain any legacy integration code. BUG: 53847
arbreng
force-pushed
the
legacy-scenic-define
branch
from
981a186 to
143b87c
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 29, 2020
jonahwilliams
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 29, 2020
* 1ae95f7 Roll Skia from 318afe66e699 to 63a0a758ce14 (4 revisions) (flutter/engine#19335) * b1b9469 Manual roll of Dart e24733ebd1...63cf56d925 (flutter/engine#19337) * de68a7f Roll Skia from 63a0a758ce14 to f123f06aabd6 (9 revisions) (flutter/engine#19336) * 220a831 Move fuchsia/scenic integration behind #define (flutter/engine#19003) * de74f8a migrate web engine implementation to null-safe Dart (flutter/engine#19172) * 4cd3ec0 Fix broken mac/fuchsia compiles (flutter/engine#19339) * 77e9f94 Roll Dart SDK from e24733ebd16c to 243ad5427564 (5 revisions) (flutter/engine#19338) * 4333fc3 Roll Dart SDK from 243ad5427564 to 7fc61e77e225 (5 revisions) (flutter/engine#19342) * b3cfbd2 Roll Fuchsia Mac SDK from YGK_M... to l3tHO... (flutter/engine#19343) * a28b7f0 Implement onDisplayPlatformView (flutter/engine#19344) * 1a4f38f Roll Dart SDK from 7fc61e77e225 to 871f0ee31eb0 (4 revisions) (flutter/engine#19346) * 3d61564 Roll Fuchsia Linux SDK from _d0dW... to Y_dK2... (flutter/engine#19347) * 727a38d Roll Fuchsia Mac SDK from l3tHO... to SuveI... (flutter/engine#19348) * ccfa0e7 Roll Fuchsia Linux SDK from Y_dK2... to lgSTC... (flutter/engine#19349) * 2ff740e Roll Dart SDK from 871f0ee31eb0 to f91547d6dd45 (1 revision) (flutter/engine#19350) * 692dfb3 update compilation rules for null-safety (flutter/engine#19386) * 729ca5e Roll Fuchsia Linux SDK from lgSTC... to ScRia... (flutter/engine#19389)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
* 1ae95f7 Roll Skia from 318afe66e699 to 63a0a758ce14 (4 revisions) (flutter/engine#19335) * b1b9469 Manual roll of Dart e24733ebd1...63cf56d925 (flutter/engine#19337) * de68a7f Roll Skia from 63a0a758ce14 to f123f06aabd6 (9 revisions) (flutter/engine#19336) * 220a831 Move fuchsia/scenic integration behind #define (flutter/engine#19003) * de74f8a migrate web engine implementation to null-safe Dart (flutter/engine#19172) * 4cd3ec0 Fix broken mac/fuchsia compiles (flutter/engine#19339) * 77e9f94 Roll Dart SDK from e24733ebd16c to 243ad5427564 (5 revisions) (flutter/engine#19338) * 4333fc3 Roll Dart SDK from 243ad5427564 to 7fc61e77e225 (5 revisions) (flutter/engine#19342) * b3cfbd2 Roll Fuchsia Mac SDK from YGK_M... to l3tHO... (flutter/engine#19343) * a28b7f0 Implement onDisplayPlatformView (flutter/engine#19344) * 1a4f38f Roll Dart SDK from 7fc61e77e225 to 871f0ee31eb0 (4 revisions) (flutter/engine#19346) * 3d61564 Roll Fuchsia Linux SDK from _d0dW... to Y_dK2... (flutter/engine#19347) * 727a38d Roll Fuchsia Mac SDK from l3tHO... to SuveI... (flutter/engine#19348) * ccfa0e7 Roll Fuchsia Linux SDK from Y_dK2... to lgSTC... (flutter/engine#19349) * 2ff740e Roll Dart SDK from 871f0ee31eb0 to f91547d6dd45 (1 revision) (flutter/engine#19350) * 692dfb3 update compilation rules for null-safety (flutter/engine#19386) * 729ca5e Roll Fuchsia Linux SDK from lgSTC... to ScRia... (flutter/engine#19389)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the #define one can create a new flutter_runner_next executable
that does not contain any legacy integration code.
Test: Manually built all platforms, ran all unittests on Fuchsia / Linux
BUG: 53847